GH-3375: ExtendedKafkaConsumer now overrides close() #3388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artembilan
requested changes
Jul 22, 2024
spring-kafka/src/main/java/org/springframework/kafka/core/DefaultKafkaConsumerFactory.java
Outdated
Show resolved
Hide resolved
spring-kafka/src/main/java/org/springframework/kafka/core/DefaultKafkaConsumerFactory.java
Show resolved
Hide resolved
| assertThat(removals).isEmpty(); | ||
| if (closeWithTimeout) { | ||
| consumer.close(Duration.ofSeconds(10)); | ||
| } else { |
There was a problem hiding this comment.
The code style is else on a new line.
Please, run ./gradlew check locally and fix all the errors before pushing into the PR.
…n order to make sure listener.consumerRemoved() is called when the consumer is closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3375: ExtendedKafkaConsumer now overrides close() in order to make sure listener.consumerRemoved() is called when the consumer is closed