Enhanced monitoring when KMLC is batch listener #3047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because of observation does not support batch listener, add properties `observationEnabled` replace `this.containerProperties.isObservationEnabled()` for `KafkaMessageListenerContainer.ListenerConsumer`, when batch listener set false to `observationEnabled`. * add notice in micrometer.adoc * add observationEnabled replace containerProperties.isObservationEnabled() in KafkaMessageListenerContainer.ListenerConsumer
sobychacko
pushed a commit
that referenced
this pull request
Feb 21, 2024
Fixes: #3047 * because of observation does not support batch listener, add properties `observationEnabled` and replace `this.containerProperties.isObservationEnabled()` for `KafkaMessageListenerContainer.ListenerConsumer`, when batch listener set false to `observationEnabled`. * add notice in micrometer.adoc * add observationEnabled and replace containerProperties.isObservationEnabled() in KafkaMessageListenerContainer.ListenerConsumer **Auto-cherry-pick to `3.1.x`**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of observation does not support batch listener, add properties
observationEnabledreplacethis.containerProperties.isObservationEnabled()forKafkaMessageListenerContainer.ListenerConsumer, when batch listener set false toobservationEnabled.