Skip to content

Eliminate the Use of StringBuffer #2909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Eliminate the Use of StringBuffer #2909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions spring-kafka/src/main/java/org/springframework/kafka/listener/ErrorHandlingUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
import java.util.Properties;
import java.util.Set;
import java.util.function.BiConsumer;
import java.util.stream.Collectors;
import java.util.stream.StreamSupport;

import org.apache.kafka.clients.consumer.Consumer;
import org.apache.kafka.clients.consumer.ConsumerConfig;
Expand Down Expand Up @@ -189,12 +191,9 @@ private static void listen(List<RetryListener> listeners, ConsumerRecords<?, ?>
* @return the String.
*/
public static String recordsToString(ConsumerRecords<?, ?> records) {
StringBuffer sb = new StringBuffer();
records.spliterator().forEachRemaining(rec -> sb
.append(KafkaUtils.format(rec))
.append(','));
sb.deleteCharAt(sb.length() - 1);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the above implementation also throws exception when records is an empty one

return sb.toString();
return StreamSupport.stream(records.spliterator(), false)
.map(KafkaUtils::format)
.collect(Collectors.joining(","));
}

/**
Expand Down
2 changes: 1 addition & 1 deletion spring-kafka/src/main/java/org/springframework/kafka/support/LoggingProducerListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public void setMaxContentLogged(int maxContentLogged) {
@Override
public void onError(ProducerRecord<K, V> record, @Nullable RecordMetadata recordMetadata, Exception exception) {
this.logger.error(exception, () -> {
StringBuffer logOutput = new StringBuffer();
StringBuilder logOutput = new StringBuilder();
logOutput.append("Exception thrown when sending a message");
if (this.includeContents) {
logOutput.append(" with key='")
Expand Down