GH-2604: Fix Transaction Synch Regression #2605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves spring-projects#2604 Prior to spring-projects#2005 synchronized transactions were committed in `afterCompletion`. This was incorrect because a failure to commit was not propagated to the caller. However, if a higher order synchronization throws an exception in `afterCommit`, the producer is closed (returned to the cache) while still in a transaction - the transaction was not committed. Restore the commit in `afterCompletion` and add a check in `KafkaResourceHolder` to only commit once. Add tests. **cherry-pick to 2.9.x**
artembilan
pushed a commit
that referenced
this pull request
Mar 2, 2023
Resolves #2604 Prior to #2005 synchronized transactions were committed in `afterCompletion`. This was incorrect because a failure to commit was not propagated to the caller. However, if a higher order synchronization throws an exception in `afterCommit`, the producer is closed (returned to the cache) while still in a transaction - the transaction was not committed. Restore the commit in `afterCompletion` and add a check in `KafkaResourceHolder` to only commit once. Add tests. **cherry-pick to 2.9.x**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2604
Prior to #2005 synchronized transactions were committed in
afterCompletion. This was incorrect because a failure to commit was not propagated to the caller. However, if a higher order synchronization throws an exception inafterCommit, the producer is closed (returned to the cache) while still in a transaction - the transaction was not committed.Restore the commit in
afterCompletionand add a check inKafkaResourceHolderto only commit once.Add tests.
cherry-pick to 2.9.x