Skip to content

GH-2516: Fix code example in the documentation for for Non-Blocking Retries - DLT Failure Behavior #2517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

GH-2516: Fix code example in the documentation for for Non-Blocking Retries - DLT Failure Behavior #2517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
65fb8a2
Fixes GH-2516
jucosorin Dec 21, 2022
d0a2362
Merge branch 'spring-projects:main' into GH-2516
jucosorin Jan 23, 2023
2db221b
Fixes GH-2516
jucosorin Jan 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions spring-kafka-docs/src/main/asciidoc/retrytopic.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -840,7 +840,7 @@ The framework provides a few strategies for working with DLTs. You can provide a

===== Dlt Processing Method

You can specify the method used to process the Dlt for the topic, as well as the behavior if that processing fails.
You can specify the method used to process the DLT for the topic, as well as the behavior if that processing fails.

To do that you can use the `@DltHandler` annotation in a method of the class with the `@RetryableTopic` annotation(s).
Note that the same method will be used for all the `@RetryableTopic` annotated methods within that class.
Expand Down Expand Up @@ -870,7 +870,7 @@ The DLT handler method can also be provided through the RetryTopicConfigurationB
public RetryTopicConfiguration myRetryTopic(KafkaTemplate<Integer, MyPojo> template) {
return RetryTopicConfigurationBuilder
.newInstance()
.dltProcessor("myCustomDltProcessor", "processDltMessage")
.dltHandlerMethod("myCustomDltProcessor", "processDltMessage")
.create(template);
}

Expand Down Expand Up @@ -923,7 +923,7 @@ public void processMessage(MyPojo message) {
public RetryTopicConfiguration myRetryTopic(KafkaTemplate<Integer, MyPojo> template) {
return RetryTopicConfigurationBuilder
.newInstance()
.dltProcessor(MyCustomDltProcessor.class, "processDltMessage")
.dltHandlerMethod("myCustomDltProcessor", "processDltMessage")
.doNotRetryOnDltFailure()
.create(template);
}
Expand Down
2 changes: 1 addition & 1 deletion spring-kafka/src/main/java/org/springframework/kafka/retrytopic/RetryTopicConfigurer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@
* public RetryTopicConfiguration otherRetryTopic(KafkaTemplate&lt;Integer, MyPojo&gt; template) {
* return RetryTopicConfigurationBuilder
* .newInstance()
* .dltProcessor(MyCustomDltProcessor.class, "processDltMessage")
* .dltHandlerMethod("myCustomDltProcessor", "processDltMessage")
* .create(template);
* }</code>
*
Expand Down