GH-2332: Fix Container.pause() with Manual Assign. #2333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves spring-projects#2332 Use manual assignments, if present, for pause. Also, in the rebalance listener, use `isPaused()` rather than `consumerPaused` to determine whether the partitions should be paused. Add logs and events for pauses in the rebal listener. Revert errant log4j commit. **cherry-pick to 2.9.x, 2.8.x**
artembilan
requested changes
Jul 6, 2022
...ng-kafka/src/main/java/org/springframework/kafka/listener/KafkaMessageListenerContainer.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Artem Bilan <[email protected]>
artembilan
requested changes
Jul 6, 2022
| this.logger.debug(() -> "Paused consumption from: " + this.consumer.paused()); | ||
| publishConsumerPausedEvent(this.consumer.assignment()); | ||
| Collection<TopicPartition> assigned = getAssignedPartitions(); | ||
| if (!CollectionUtils.isEmpty(assigned)) { |
There was a problem hiding this comment.
I guess this one has to come together with an import org.springframework.util.CollectionUtils;
|
Cherry-picked to |
|
Back ported to 2.8.x; found a problem during the back port - fixed there, as well as on main and 2.9.x a63359c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2332
Use manual assignments, if present for pause.
Also, in the rebalance listener, use
isPaused()rather thanconsumerPausedto determine whether the partitions should be paused.
Add logs and events for pauses in the rebal listener.
cherry-pick to 2.9.x, 2.8.x