Fix for Issue #1482 - Allow update of topic-config during topic modification via NewTopic #1823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added method to adjust mismatches in topic-config Added test for mismatch adjustment
|
@marekschwarz Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@marekschwarz Thank you for signing the Contributor License Agreement! |
garyrussell
reviewed
Jun 7, 2021
|
|
||
| private Map<ConfigResource, List<ConfigEntry>> checkTopicsForConfigMismatches( | ||
| AdminClient adminClient, Collection<NewTopic> topics) { | ||
| List<ConfigResource> configResources = topics.stream() |
There was a problem hiding this comment.
We like to add a blank line before code when the method signature wraps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1482.
Needs refactoring, but wanted to share the code already to get some feedback.