GH-1008: Use transactional.id config as a prefix
#1065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spring-projects#1008 * If provided `configs` for the `DefaultKafkaProducerFactory` contains a `ProducerConfig.TRANSACTIONAL_ID_CONFIG` value, treat it as a `prefix` and override for the target `Producer` configs. Also log an `INFO` that this value is going to be prefix the target `Producer` * An explicit `setTransactionIdPrefix()` will override this value any way * Polishing for `KafkaTemplateTransactionTests` together with an explicit `ProducerConfig.TRANSACTIONAL_ID_CONFIG` config in the `testLocalTransaction()` test
garyrussell
suggested changes
Apr 11, 2019
|
|
||
| String txId = (String) this.configs.get(ProducerConfig.TRANSACTIONAL_ID_CONFIG); | ||
| if (StringUtils.hasText(txId)) { | ||
| setTransactionIdPrefix(txId); |
There was a problem hiding this comment.
Needs to be made final when calling from a CTOR. Perhaps add a protected getter if a subclass wants to sniff the value.
There was a problem hiding this comment.
It is there. See the change on line 186.
I'm OK to add getter.
There was a problem hiding this comment.
Doh, I missed it because of all the other noise 😦 sorry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1008
configsfor theDefaultKafkaProducerFactorycontains aProducerConfig.TRANSACTIONAL_ID_CONFIGvalue, treat it as aprefixand override for the target
Producerconfigs.Also log an
INFOthat this value is going to be prefix the targetProducersetTransactionIdPrefix()will override this valueany way
KafkaTemplateTransactionTeststogether with anexplicit
ProducerConfig.TRANSACTIONAL_ID_CONFIGconfig in thetestLocalTransaction()test