EmbeddedKafkaRule does not delete temporary directories

[apanasevich]

Hi,

I've faced the problem that EmbeddedKafkaRule does not delete temporary directories. Here is a simple example https://github.com/apanasevich/embeded-kafka-rule

Every run of EmbededKafkaTest#example on Windows leaves non-empty directory with zookeeper log file in user's temporary directory.

[artembilan]

We do in the after() implementation of the rule something like this:

CoreUtils.delete(kafkaServer.config().logDirs());
...
this.zookeeper.shutdown();

So, if you say that dirs are still there in the tmp user dir, then it is not what we can control from Spring level.

I would recommend to consult with Apache Kafka on the matter if you find this as a problem.

I use Windows as well and the latest Kafka client works pretty stable for me here. I might just not noticed those dirs in my tmp though, but according the code it doesn't look like we can do anything else to clean up them properly.

[apanasevich]

I might just not noticed those dirs in my tmp though, but according the code it doesn't look like we can do anything else to clean up them properly.

I tend to consider the problem as a serious one. For example, a single run of a bunch of twenty tests leaves ~1Gb of garbage on a system disk (64Mb per test). It's easy to get "No disc space".

So, if you say that dirs are still there in the tmp user dir, then it is not what we can control from Spring level

I've created a PR with a fix. Please, consider it.

[apanasevich]

I've created an issue in Apache tracker.

[FNaughton]

Looks like might be related to / has same root cause as - https://issues.apache.org/jira/browse/KAFKA-6647

[artembilan]

Closed as Won't Fix.
See mentioned above Apache Kafka JIRAs.
Should be addressed automatically after upgrade into a Kafka Client version with the fix.