-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Closed
Milestone
Description
In what version(s) of Spring for Apache Kafka are you seeing this issue?
current main
Describe the bug
CommonMixedErrorHandler constructor check recordErrorHandler twice
public CommonMixedErrorHandler(CommonErrorHandler recordErrorHandler, CommonErrorHandler batchErrorHandler) {
Assert.notNull(recordErrorHandler, "'recordErrorHandler' cannot be null");
Assert.notNull(recordErrorHandler, "'batchErrorHandler' cannot be null");
this.recordErrorHandler = recordErrorHandler;
this.batchErrorHandler = batchErrorHandler;
}
To Reproduce
Steps to reproduce the behavior.
Expected behavior
i think second assert have to check batchErrorHandler
public CommonMixedErrorHandler(CommonErrorHandler recordErrorHandler, CommonErrorHandler batchErrorHandler) {
Assert.notNull(recordErrorHandler, "'recordErrorHandler' cannot be null");
Assert.notNull(batchErrorHandler, "'batchErrorHandler' cannot be null");
this.recordErrorHandler = recordErrorHandler;
this.batchErrorHandler = batchErrorHandler;
}
thanks for reading