Polish #9505
Merged
Polish #9505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artembilan
reviewed
Sep 23, 2024
| @@ -249,8 +250,8 @@ public void removeDeadConnection(TcpConnection connection) { | |||
| return; | |||
| } | |||
| this.removed = true; | |||
| if (this.theConnection instanceof TcpConnectionInterceptorSupport && !this.theConnection.equals(this)) { | |||
| ((TcpConnectionInterceptorSupport) this.theConnection).removeDeadConnection(this); | |||
| if (this.theConnection instanceof TcpConnectionInterceptorSupport tcpConnectionInterceptorSupport && !this.theConnection.equals(this)) { | |||
There was a problem hiding this comment.
I probably will accept this PR as is.
Due to its size and simplicity, but for the future contributions, please, consider to make code lines not more than 120 symbols.
|
Thank you for very much for the contribution; looking forward for more! Please, consider these rules for commit messages in the future: https://cbea.ms/git-commit/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
#isEmptycondition