GH-3509: Fix Memory Leak with Intercepted TCP Conn #3518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves spring-projects#3509 When a connection was intercepted, the `TcpSender.add...` was called with the interceptor, but the `removeDead...` was called with the actual connection, causing a memory leak. Always call the `TcpSender` with the outer-most interceptor.
artembilan
requested changes
Mar 17, 2021
| } | ||
| }); | ||
| TcpConnectionInterceptorFactoryChain fc = new TcpConnectionInterceptorFactoryChain(); | ||
| fc.setInterceptor(newInterceptorFactory(scf.getApplicationEventPublisher())); |
There was a problem hiding this comment.
Does it work now if we override a getConnectionId() in the HelloWorldInterceptor?
There was a problem hiding this comment.
Yes, because the same object (the outermost interceptor) is always used for addNewConnection an removeDeadConnection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3509
When a connection was intercepted, the
TcpSender.add...was called with theinterceptor, but the
removeDead...was called with the actual connection,causing a memory leak.
Always call the
TcpSenderwith the outer-most interceptor.Cherry-pick to master after reverting previous fix