INT-3724: Gateway - Support CompletableFuture #1463
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA: https://jira.spring.io/browse/INT-3724 Add support for `CompletableFuture<?>` return types on gateway methods, if JDK8 is being used. - If the return type is exactly `CompletableFuture` and an async executor is provided, use `CompletableFuture.supplyAsync()` - If there is no return async executor, return types can be `CompletableFuture` or a subclass and the flow can return such a future. - Also fixes a problem for return type `Future<Message<?>>` with no async executor; previously this caused a `ClassCastException` because the gateway returned the message - it assumed such return types would always run on an excutor. We can consider back-porting this last part, but nobody has complained.
| @@ -72,6 +82,13 @@ public void registerBeanDefinitions(AnnotationMetadata importingClassMetadata, B | |||
| } | |||
|
|
|||
| public BeanDefinitionHolder parse(Map<String, Object> gatewayAttributes) { | |||
| boolean completableFutureCapable = true; | |||
| try { | |||
| ClassUtils.forName("java.util.concurrent.CompletableFuture", this.beanClassLoader); | |||
There was a problem hiding this comment.
Since this one is a part of JVM I don't see reason to worry about classloader.
Although you have already done that we can live with that and merge as is.
|
Pushed docs |
| If `DEBUG` logging is enabled, a log is emitted indicating that the async executor cannot be used for this scenario. | ||
|
|
||
|
|
||
| `CompletionFuture` s can be used to perform additional manipulation on the reply, such as: |
There was a problem hiding this comment.
Is this intentional word?
" CompletableFuture s " ?
Let me know and I fix it and merge.
|
Merged as 5e9624f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.spring.io/browse/INT-3724
Add support for
CompletableFuture<?>return types on gateway methods, if JDK8 is being used.CompletableFutureand an async executor is provided, useCompletableFuture.supplyAsync()CompletableFutureor a subclass and the flow can return such a future.Future<Message<?>>with no async executor; previously this caused aClassCastExceptionbecause the gateway returned the message - it assumed such return types would always run on an excutor.
We can consider back-porting this last part, but nobody has complained.
TODO: Docs, after review