-
Notifications
You must be signed in to change notification settings - Fork 38.5k
Support CompletableFuture<> as return type of @Async methods [SPR-13128] #17719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Juergen Hoeller commented Good idea, and a nice fit with our existing Juergen |
Gary Russell commented Also see spring-projects/spring-integration#1463 for |
Thomas Darimont commented Thanks for adding that :) Would it be possible to get that backported to 4.1.x? Cheers, |
Juergen Hoeller commented I'm afraid not since it's a new feature which benefits from going through a release candidate phase... It also ties nicely into our general I talked about this with Ollie yesterday, and there seems to be nothing preventing you from shipping Juergen |
Sam Brannen commented Reopening since this appears to break See failing Performance builds for details:
|
Juergen Hoeller commented Oops, I added a test for the AspectJ variant of processing here but apparently forgot to put the actual code for it into the aspect implementation... So effectively, just the interceptor-based variant worked. Fixed now, with the common Juergen |
Sam Brannen commented Aha! Glad you sorted it out with a late night coding session... just before 4.2 RC2. ;) |
Didier Loiseau commented Is the support of |
Oliver Drotbohm commented Good one. I've filed #19447 to improve the documentation on that. |
Uh oh!
There was an error while loading. Please reload this page.
Thomas Darimont opened SPR-13128 and commented
Currently
@Async
annotated methods support to return Future<> result wrappers via AsyncResult<> it would be great if we would support CompletableFuture here as well.I created a small example that adds the necessary functionality to
AsyncExecutionInterceptor
.Usage:
Consumer:
Reference URL: https://gist.github.com/thomasdarimont/197e92e537554634adbd
Issue Links:
@MessageMapping
handlers@Async
methodsReferenced from: commits dd4bc63, c41779f, 581ab18
0 votes, 7 watchers
The text was updated successfully, but these errors were encountered: