Skip to content

Code cleanup #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gregturn opened this issue Aug 30, 2019 · 0 comments
Closed

Code cleanup #1059

gregturn opened this issue Aug 30, 2019 · 0 comments
Assignees
@gregturn
Labels
in: core Core parts of the project polish
Milestone
1.0.0.RC2

Comments

@gregturn
Copy link
Contributor

Various leftovers from the Java 6 and 7 days needs to be cleaned up.
@gregturn gregturn added the in: core Core parts of the project label Aug 30, 2019
@gregturn gregturn added this to the 1.0.0.RC2 milestone Aug 30, 2019
@gregturn gregturn self-assigned this Aug 30, 2019
gregturn added a commit that referenced this issue Aug 30, 2019
@gregturn
#1059 - Cleanup the core codebase.
fff5396 
Clean up code containing various patterns:

* Remove redundant `final`, `public`, and `static` declarations in interfaces and enums.
* Replace redundant `? extends Object` generic parameters with `?`.
* Convert collections to arrays using empty array instead of pre-sized one (modern JVM recommendation).
* Initialize collections using constructor call over `addAll`.
* Favor `addAll` over iterating and adding one-by-one.
* Take advantage of `Map.forEach` that was introduced with Java 8.
gregturn added a commit that referenced this issue Aug 31, 2019
@gregturn
#1059 - Polishing.
e5669ee
@gregturn gregturn closed this as completed Sep 4, 2019
@gregturn gregturn added the polish label Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregturn gregturn

Labels
in: core Core parts of the project polish
Projects
None yet
Milestone
1.0.0.RC2
Development

No branches or pull requests
1 participant
@gregturn