Skip to content

Conversation

@ianbrandt
Copy link
Contributor

Original patch by Michel Zanini.

Issue: SPR-9235

Per the JIRA comments hopefully this will be backported to 3.1.2.

I have signed and agree to the terms of the SpringSource Individual Contributor License Agreement.

Original patch by Michel Zanini.

Issue: SPR-9235
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remember to remove the ` character from this string when applying this patch. As far as I know, this escape character will only work for MySQL.

@ianbrandt
Copy link
Contributor Author

I'm hoping to get at least the existing methods into a point release as soon as possible. Perhaps the new methods should really be included in a separate pull request? The existing methods lack test coverage as well, but they're just being migrated unchanged.

I could perhaps add some in-memory test coverage with H2 using its compatibility modes. The documentation for MySQL mode doesn't say anything about ``` as an escape character, but I could request enhancements as needed. These would be more integration tests as opposed to unit tests however, and they wouldn't run as fast accordingly. I'm not sure what the Spring policy is on this?

@ghost ghost assigned sbrannen Aug 3, 2012
sbrannen added a commit that referenced this pull request Aug 3, 2012
* SPR-9235:
  Deprecate SimpleJdbcTestUtils in favor of JdbcTestUtils
@sbrannen sbrannen closed this Aug 3, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants