Skip to content

Ensure Spring LogFactory contains all public methods from Apache LogFactory #30668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 21, 2023
Merged

Ensure Spring LogFactory contains all public methods from Apache LogFactory #30668

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c9e264
Make sure Spring LogFactory contains all the public methods from Apac…
maartenc Jun 14, 2023
a8bbf0e
Reworked based on review comments
maartenc Jun 20, 2023
cc47252
Merge branch 'spring-projects:main' into LogFactory_setAttribute
maartenc Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions spring-jcl/src/main/java/org/apache/commons/logging/LogFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,4 +102,31 @@ public Log getInstance(String name) {
return getLog(name);
}

// Just in case some code happens to call uncommon Commons Logging methods...

@Deprecated
public Object getAttribute(String name) {
return null;
}

@Deprecated
public String[] getAttributeNames() {
return new String[0];
}

@Deprecated
public void removeAttribute(String name) {
// do nothing
}

@Deprecated
public void setAttribute(String name, Object value) {
// do nothing
}

@Deprecated
public void release() {
// do nothing
}

}