Skip to content

Support URI templates in RequestEntity #24406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

parviz-93
Copy link
Contributor

@parviz-93 parviz-93 commented Jan 20, 2020

Add String based URI template and vararg to builder #22083

@parviz-93 parviz-93 requested a review from rstoyanchev January 20, 2020 18:06
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 20, 2020
@rstoyanchev rstoyanchev self-assigned this Jan 22, 2020
@rstoyanchev rstoyanchev added this to the 5.3 M1 milestone Jan 22, 2020
@rstoyanchev rstoyanchev added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jan 22, 2020
Copy link
Contributor

@rstoyanchev rstoyanchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall on the right path.

In addition to line specific comments, this is lacking the change where the RestTemplate uses the new getUrl(UriTemplateHandler) method instead of getUrl() which would add the benefits of a pre-configured base URL among others. That was the following step from the instructions:

  1. Make use of this new method in RestTemplate.

Keep in mind also this cannot be merged at the moment until we switch master to 5.3 development.

Copy link
Contributor

@rstoyanchev rstoyanchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making good progress. I've added more comments.

@rstoyanchev
Copy link
Contributor

Thanks for all the updates! This is now in good shape for inclusion. When master is switched to 5.3 development I'll process this right away.

@parviz-93
Copy link
Contributor Author

@rstoyanchev thank you for review. if there are issues which your hands do not reach, I am always ready to help

@rstoyanchev
Copy link
Contributor

Thanks! Keep an eye on the "ideal-for-contribution" label.

@rstoyanchev rstoyanchev changed the title Add String based URI template variants Support URI templates in RequestEntity May 6, 2020
rstoyanchev added a commit that referenced this pull request May 6, 2020
@jhoeller
Copy link
Contributor

jhoeller commented Jun 8, 2020

@rstoyanchev I'm afraid we have do revisit this one since it turned out to create a package cycle between org.springframework.http (where RequestEntity lives) and org.springframework.web (where UriTemplateHandler lives). We'll have to put this getUrl overload into some utility method or introduce a dedicated RequestEntity subclass in the org.springframework.web package which may then integrate with specific facilities such as UriTemplateHandler there.

@jhoeller jhoeller reopened this Jun 8, 2020
rstoyanchev added a commit that referenced this pull request Jun 15, 2020
@rstoyanchev
Copy link
Contributor

This should be taken care of now.

kenny5he pushed a commit to kenny5he/spring-framework that referenced this pull request Jun 21, 2020
kenny5he pushed a commit to kenny5he/spring-framework that referenced this pull request Jun 21, 2020
kenny5he pushed a commit to kenny5he/spring-framework that referenced this pull request Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants