-
Notifications
You must be signed in to change notification settings - Fork 38.6k
Support URI templates in RequestEntity #24406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall on the right path.
In addition to line specific comments, this is lacking the change where the RestTemplate
uses the new getUrl(UriTemplateHandler)
method instead of getUrl()
which would add the benefits of a pre-configured base URL among others. That was the following step from the instructions:
- Make use of this new method in RestTemplate.
Keep in mind also this cannot be merged at the moment until we switch master to 5.3 development.
spring-web/src/main/java/org/springframework/http/RequestEntity.java
Outdated
Show resolved
Hide resolved
spring-web/src/main/java/org/springframework/http/RequestEntity.java
Outdated
Show resolved
Hide resolved
a3a5ac6
to
2688ad8
Compare
2688ad8
to
3791caa
Compare
3791caa
to
4101982
Compare
4101982
to
e4e7a32
Compare
spring-web/src/main/java/org/springframework/http/RequestEntity.java
Outdated
Show resolved
Hide resolved
e4e7a32
to
54d5d7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making good progress. I've added more comments.
spring-web/src/test/java/org/springframework/http/RequestEntityTests.java
Show resolved
Hide resolved
54d5d7c
to
f8b2f40
Compare
Thanks for all the updates! This is now in good shape for inclusion. When master is switched to 5.3 development I'll process this right away. |
@rstoyanchev thank you for review. if there are issues which your hands do not reach, I am always ready to help |
Thanks! Keep an eye on the "ideal-for-contribution" label. |
@rstoyanchev I'm afraid we have do revisit this one since it turned out to create a package cycle between |
This should be taken care of now. |
Add String based URI template and vararg to builder #22083