Skip to content

Conversation

kohlmu-pivotal
Copy link

Adding Kotlin code examples to Testing documentation.
See - gh-21778

@pivotal-issuemaster
Copy link

@kohlmu-pivotal Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@kohlmu-pivotal Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Aug 30, 2019
@sdeleuze sdeleuze self-assigned this Aug 30, 2019
@sdeleuze sdeleuze added this to the 5.2 RC2 milestone Aug 30, 2019
@sdeleuze sdeleuze added type: documentation A documentation task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Aug 30, 2019
Copy link
Member

@sbrannen sbrannen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert all lines that add a public modifier in Java test code examples, since that effectively undoes the work performed in 53f5230.

@sdeleuze
Copy link
Contributor

Merged via a completely reworked commit via b20a8c9.

@sdeleuze sdeleuze closed this Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants