Skip to content

Fix for ScriptUtils failure when '--' occurs inside a multi-line comment on the same line as '*/' #22392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 8, 2019

Conversation

mmustaquim
Copy link
Contributor

Pull request against issue #22388

…urs on a line starting with the single-line comment prefix
…comment block where the comment-end delimiter occurs on a line starting with the single-line comment prefix.
@pivotal-issuemaster
Copy link

@mmustaquim Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@mmustaquim Thank you for signing the Contributor License Agreement!

@jhoeller jhoeller self-assigned this Feb 8, 2019
@jhoeller jhoeller added the type: enhancement A general enhancement label Feb 8, 2019
@jhoeller jhoeller added this to the 5.1.5 milestone Feb 8, 2019
@jhoeller jhoeller merged commit 82dbde1 into spring-projects:5.1.x Feb 8, 2019
@jhoeller
Copy link
Contributor

jhoeller commented Feb 8, 2019

Merged and therefore part of 5.1.5 :-) Thanks for the PR!

@mmustaquim
Copy link
Contributor Author

Cool. I didn't expect to move this quickly from issue to submission. Looking forward to the 5.1.5 release. Cheers!

@sbrannen sbrannen added the in: data Issues in data modules (jdbc, orm, oxm, tx) label Jun 29, 2020
@mmustaquim mmustaquim deleted the 5.1.x branch October 8, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants