Skip to content

Conversation

@sheiy
Copy link

@sheiy sheiy commented Oct 18, 2018

make getMethodArgumentValues from private to protected.
I want to overwrite invokeForRequest to log the request param response and processing time to the db but the method of getMethodArgumentValues is private so I want change it to protected

make getMethodArgumentValues from private to protected.
@pivotal-issuemaster
Copy link

@Sofior Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@snicoll
Copy link
Member

snicoll commented Oct 18, 2018

@Sofior we need a Jira issue to discuss this change. Can you please create one?

@sheiy
Copy link
Author

sheiy commented Oct 18, 2018

@snicoll https://jira.spring.io/browse/SPR-17404

@jhoeller
Copy link
Contributor

As per SPR-17404, I've rolled this into master in an extended fashion, declaring getMethodArgumentValues as protected in both the web and the messaging variant of InvocableHandlerMethod, with revised javadoc that explains the invocation order. Thanks for the pull request, in any case!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants