SPR-16838 PathMatchingResourcePatternResolver should enforce consistent alphabetical sorting of directory content #1832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alphabetical sorting of directory content A sort was added in SPR-14085 but the default File#compareTo depends upon the underlying system. The ordering of the ressources returned by PathMatchingResourcePatternResolver#retrieveMatchingFiles may differ between OS (Windows, Unix). This leads to subtle bugs hard to track. This PR replace the default sort with one based on the file name.
|
As per my JIRA comments, resolved in a more extensive fashion. Thanks for the pull request, in any case! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A sort was added in SPR-14085 but the default File#compareTo depends
upon the underlying system.
The ordering of the ressources returned by
PathMatchingResourcePatternResolver#retrieveMatchingFiles may differ
between OS (Windows, Unix).
This leads to subtle bugs hard to track.
This PR replace the default sort with one based on the file name.