Skip to content

SPR-15196 - Check for null on the argument instead of the message #1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

SPR-15196 - Check for null on the argument instead of the message #1307

wants to merge 1 commit into from

Conversation

Shredder121
Copy link
Contributor

Don't know if this fix is truly trivial, but let me know if a JIRA ticket is required.

I did already sign the CLA, so that should be good.

@snicoll
Copy link
Member

snicoll commented Jan 27, 2017

Thanks for the PR!

Quickly discussed this one with @jhoeller and we should probably revisit that class to avoid that kind of mistake. I've created SPR-15196

@snicoll snicoll changed the title Check for null on the argument instead of the message SPR-15196 - Check for null on the argument instead of the message Jan 27, 2017
@Shredder121
Copy link
Contributor Author

Good to hear that it's picked up so quickly!

@snicoll snicoll self-assigned this Jan 27, 2017
snicoll pushed a commit that referenced this pull request Jan 27, 2017
@Shredder121 @snicoll
Check for null on the argument instead of the message
f1c7e0f 
See gh-1307
Issue: SPR-15196
@snicoll snicoll closed this in d550eb1 Jan 27, 2017
snicoll added a commit that referenced this pull request Jan 27, 2017
@snicoll
Merge pull request #1307 from Shredder121:assert-message
33f0995 
* pr/1307:
  Polish contribution
  Check for null on the argument instead of the message
@Shredder121 Shredder121 deleted the assert-message branch January 27, 2017 13:21
@Shredder121
Copy link
Contributor Author

👍

@spring-projects-issues spring-projects-issues mentioned this pull request Jan 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@snicoll snicoll

@jhoeller jhoeller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shredder121 @snicoll @jhoeller