SpringJUnit4ClassRunner doesn't catch AssumptionViolatedException in @Before methods [SPR-4570]

[spring-projects-issues]

Noel Flicken opened SPR-4570 and commented

Spring's JUnit4 SpringMethodRoadie doesn't catch a AssumptionViolatedException in #runBefores, differing in functionality from JUnit4's MethodRoadie#runBefores.

The below test class succeeds (via assumption being false) with JUnit4ClassRunner, but fails with SpringJUnit4ClassRunner (due to AssumptionViolatedException being thrown in assumeFalse()).

public static class BeforeMethodTest {
@Before
public void assumeFalse()
{
assumeTrue(false);
}

@Test public void failure()
{
	fail("Before method test");
}

}

Attaching a test case to illustrate.

---

Attachments:

• AssertFalse.java (1.67 kB)
• SpringMethodRoadie.patch (1.21 kB)

[spring-projects-issues]

Noel Flicken commented

Add AssertFalse.java, containing tests cases illustrating bug.

[spring-projects-issues]

Noel Flicken commented

Attached proposed patch: SpringMethodRoadie.patch

[spring-projects-issues]

Juergen Hoeller commented

Thanks for pointing this out - I've fixed this for 2.5.3. Should be available in the next 2.5.3 snapshot.

Interestingly, we had an odd junit-4.4.jar in our libraries: a version that didn't catch AssumptionViolatedException there in the standard MethodRoadie class either. This is where we derived our code from... I've replaced this with a fresh official JUnit 4.4 download now, which does contain that AssumptionViolatedException check in "runBefores()".

Juergen

[spring-projects-issues]

Noel Flicken commented

Thanks for the quick fix. Using spring-test on a project, and noticed the discrepancy when trying to use assertThat.