HibernateTemplate gets overwritten when using autowire on HibernateDaoSupport [SPR-4559]

[spring-projects-issues]

John Zhang opened SPR-4559 and commented

When using autowire, SessionFactory will be automatically injected into HibernateDaoSupport. If user also specify a HibernateTemplate, it will be overwritten, which is not desired since user may have customized settings on HibernateTemplate.

In HibernateDaoSupport,

public final void setSessionFactory(SessionFactory sessionFactory) {
  this.hibernateTemplate = createHibernateTemplate(sessionFactory);
}

Should it be something like this?

if ( this.hibernateTemplate == null ){
    this.hibernateTemplate = createHibernateTemplate(sessionFactory);
}

---

Affects: 2.5.1

[spring-projects-issues]

Juergen Hoeller commented

Good point - I've added such a check for 2.5.3.

Juergen