In case of Exception, exceptionListener is never invoked by DefaultMessageListenerContainer [SPR-4546]

[spring-projects-issues]

Sourabh Srivastava opened SPR-4546 and commented

In case of JMSExceptions, DefaultMessageListenerContainer is not invoking the class configured for "exceptionListener". It is always calling the Listener class again and again every second and it is going in loop.

---

Affects: 2.5.2

[spring-projects-issues]

Juergen Hoeller commented

This should be fixed in the latest 2.5.3 snapshot already. DefaultMessageListenerContainer propagates JMSExceptions thrown from a listener now, potentially triggering recovery - and avoiding listener invocation loops. Give it a try (http://static.springframework.org/downloads/nightly/snapshot-download.php?project=SPR) and let me know whether it works for you...

Juergen

[spring-projects-issues]

Sourabh Srivastava commented

I took the snapshot and verified this issue. It is still not working.

Here is my results..

My DefaultMessageListener is configured with an MessageAdapter and MessageAdapter is invoking a delegate class.

To test this issues, from my delegate class i am throwing JMSException.

It calls MessageListenerAdapter.invokeListenerMethod(), which internally throws ListenerExecutionFailedException.

It goes back to AbstractMessageListenerContainer.doExecuteListener(), and it calls the RuntimeException catch block.

From there it goes to AbstractPollingMessageListenerContainer.doReceiveAndExecute(), calls catch block Throwable and calls handleListenerException(ex);.

Here it should go to

if (ex instanceof JMSException) {
invokeExceptionListener((JMSException) ex);
}

but it is bypassing this step as the ex instance is ListenerExecutionFailedException, not JMSException.

Hope this helps.

Thanks,
Sourabh

[spring-projects-issues]

Juergen Hoeller commented

Well, ListenerExecutionFailedException is not a JMSException so it is not eligible for being passed into a standard JMS ExceptionHandler to begin with... What would you expect to happen here?

As far as I can tell, 2.5.3 at least fixes this in terms of recovery kicking in now. You should not get listener invocation loops in such a case anymore, in contrast to previous Spring versions. Can you verify that part?

Juergen

[spring-projects-issues]

Sourabh Srivastava commented

1. If i don't put <property name="sessionTransacted" value="true" /> for DefaultMessageListenerContainer and delegate class throws error, it is not going in loop. It is exiting gracefully.

2. If i put <property name="sessionTransacted" value="true" /> for DefaultMessageListenerContainer and delegate class throws error, then it is going in loop.

3. Even if i throw JMSException from my delegate class, exceptionListener attribute of DefaultMessageListenercontainer is not getting invoked. That's what i was trying to say in my last comment. Inside spring framework classes JMSException is getting converted to ListenerExecutionFailedException.

--Sourabh

[spring-projects-issues]

Juergen Hoeller commented

Thanks for the clarification! I've revised MessageListenerAdapter to propagate JMSExceptions thrown from listener method as-is now, only wrapping non-JMS exceptions with a ListenerExecutionFailedException.

This will be available in tonight's 2.5.3 snapshot (-432 or above). Please give it a try and let me know whether it works for you...

Juergen

[spring-projects-issues]

Sourabh Srivastava commented

I tried it with the latest snapshot. It works but i noticed that exceptionListener class is called around 5-6 times. I guess when JMSException is thrown, it is trying to close down resources, which are again throwing JMSException and this whole process goes for 4-5 times.

here are few log messages from my code --

Message from Sourabh's Exception Listener Class
test Message
[ INFO] 23:11:06 DefaultMessageListenerContainer - Setup of JMS message listener invoker failed - trying to recover: javax.jms.JMSException: test Message
[ INFO] 23:11:06 DefaultMessageListenerContainer - Successfully refreshed JMS Connection
Message from Sourabh's Exception Listener Class
Consumer is closed
Message from Sourabh's Exception Listener Class
Consumer is closed
Message from Sourabh's Exception Listener Class
Consumer is closed
Message from Sourabh's Exception Listener Class
Consumer is closed

All i am throwing from my delegate class is throw new JMSMessage{"test message")

[spring-projects-issues]

Juergen Hoeller commented

What does the stacktrace for those "Consumer is closed" exceptions look like? I'll try to revise the affected resource access sections...

Juergen