Lenient URI parsing in ServletServerHttpRequest

[alexisgayte]

Linked to #25274 , #30475

url with relaxed char are not allowed even with the option set.
Url example : /test?id={64aaa32-3f4e-93b0-9cd9-986a0a34a650}

using reactive and tomcat with TomcatHttpHandlerAdapter, this url call will fail down the route.
as ServletHttpHandlerAdapter creates a ServletServerHttpRequest that tries to parse the url with java.net.URI which doesn't allow relaxed-query-chars.

The issue is here :

spring-framework/spring-web/src/main/java/org/springframework/http/server/reactive/ServletServerHttpRequest.java

Line 131 in c227fbf

return new URI(url.toString());

the URI parser doesn't allow relaxed char.

Error thrown is : ServletHttpHandlerAdapter - Failed to get request URL: Illegal character in query at

[alexisgayte]

For anyone facing this issue. Here my work around.

Work around is to monkey patch the java.net.URI class

Uncomment lowMask and highMask.

replacing L_MARK and H_MARK to add your relaxed characters.
for example in my case :

    private static final long L_MARK = lowMask("-_.!~*'(){}");
    private static final long H_MARK = highMask("-_.!~*'(){}");

[sreeraksha]

Hi @alexisgayte,

Could you please ellaborate on how I can monkey patch java.net.RMI class by giving a more detailed example.

[alexisgayte]

with Java 8, just add the tweaked java.net.URI into your project. It will override it.
With java 9 + you will need to patch the java.base module.

something like that :
javac --patch-module java.base=src -d build/classes/java/patches //src/patches/java/java/net/URI.java
java --patch-module java.base=build/classes/java/patches

cf https://openjdk.org/projects/jigsaw/

Then you need to integrate it with your project builder.
With gradle I ended up with something like that :

sourceSets {
    patches
    main {
        compileClasspath += sourceSets.patches.output
        runtimeClasspath += sourceSets.patches.output
    }
}

bootRun {
    jvmArgs = ['--patch-module', 'java.base=build/classes/java/patches']
}

compilePatchesJava {
    options.fork = true
    options.forkOptions.executable = 'javac'
    options.compilerArgs.addAll(['--patch-module', 'java.base=src'])
}

with your URI class in it.

[MangalaEkanayake]

Does this have fixed in a recent Spring framework?

[alexisgayte]

I don't think so.

[ahoka]

It should just pass it as a String, IMHO.

[snicoll]

I am a little bit confused by the report. You're talking about reactive and tomcat and the code that you link is from Spring MVC. I took the time to rebuild a small sample based on your description and it works fine.

If you want support, please provide a small sample that we can run ourselves that reproduces the issue. You can attach it as a zip or you can push the code to a GitHub repository. Please note that while Spring Framework 5.3.x is still supported in OSS, Spring Boot 2.x is not.

[alexisgayte]

Hi Shephane,
Thanks for your time over the festive holiday.
This report came after I use spring cloud gateway. It is definitely reactive the path in the link shows reactive ( thinking, I might miss something on what you mean by reactive ).
I am not able to create a case right now. But the URI class that is used don't allow relaxed char in the parsing process so I doubt that's work.

This was with spring boot 3.1.7 and I believe it hasn't changed with 3.2.1

BTW I am a big fan of your work. Thanks for all your work.