Skip to content

Improve R2DBC DatabaseClient documentation regarding array/Collection-like bind parameters #25860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mp911de opened this issue Oct 6, 2020 · 0 comments
Assignees
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: documentation A documentation task
Milestone

Comments

@mp911de
Copy link
Member

mp911de commented Oct 6, 2020

Based on spring-projects/spring-data-r2dbc#474, the documentation showing usage of Collection-like bind parameters leads to an assumption, that collection values can be used also for updating array columns.

We should clarify by adding a note that R2DBC doesn't support Collection-like values and this feature is solely a Spring feature. We also should mention that inserting/updating array-typed columns (as in Postgres) requires an array-type that is supported by the R2DBC driver, which are typically Java arrays (e.g. String[] to update a text[] column instead of using Collection<String>).

I can submit a pull request to update the docs.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Oct 6, 2020
@jhoeller jhoeller added in: data Issues in data modules (jdbc, orm, oxm, tx) type: documentation A documentation task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Oct 6, 2020
@jhoeller jhoeller added this to the 5.3 GA milestone Oct 6, 2020
@jhoeller jhoeller self-assigned this Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: documentation A documentation task
Projects
None yet
Development

No branches or pull requests

3 participants