Skip to content

Provide access to non-standard status codes from ServerHttpResponse #23547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wilkinsona opened this issue Aug 30, 2019 · 2 comments
Closed

Provide access to non-standard status codes from ServerHttpResponse #23547

wilkinsona opened this issue Aug 30, 2019 · 2 comments
Assignees
@jhoeller
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement

Comments

@wilkinsona
Copy link
Member

In a similar vein to #22872, it would be useful to have access to the raw status code rather than null when dealing with a response with a status code that is not known to HttpStatus.
@wilkinsona wilkinsona mentioned this issue Aug 30, 2019
Closed
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Aug 30, 2019
@jhoeller jhoeller added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Sep 5, 2019
@jhoeller jhoeller added this to the 5.2 GA milestone Sep 5, 2019
@jhoeller jhoeller self-assigned this Sep 5, 2019
@wilkinsona wilkinsona mentioned this issue Sep 12, 2019
Closed
@jhoeller
Copy link
Contributor

This is available in some form (managing locally set status code values outside of the enum range) on AbstractServerHttpResponse - would a downcast be sufficient for your purposes?

Since the ServerHttpResponse interface is more about modifying than introspecting the response, I'm rather reluctant to add further introspection methods to the interface.

@wilkinsona wilkinsona mentioned this issue Sep 18, 2019
Closed
@wilkinsona
Copy link
Member Author

Yes, that works nicely. Thanks for the suggestion.

@jhoeller jhoeller removed this from the 5.2 GA milestone Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wilkinsona @jhoeller @spring-projects-issues