Skip to content

Migrate tests to AssertJ #23022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
philwebb opened this issue May 23, 2019 · 2 comments
Closed

Migrate tests to AssertJ #23022

philwebb opened this issue May 23, 2019 · 2 comments
Assignees
@sbrannen @philwebb
Labels
type: task A general task
Milestone
5.2 M3

Comments

@philwebb
Copy link
Member

Commits d7320de and 02850f3 for #22894 have already started the process of migrating exception checking tests to AssertJ but there's a lot of benefit in migrating all remaining assertions as well. Tests will be easier to read if they all use the same assertion style, and a wholesale migration to JUnit 5 will be much easier.
@philwebb philwebb added this to the 5.2 M3 milestone May 23, 2019
@philwebb philwebb self-assigned this May 23, 2019
philwebb added a commit that referenced this issue May 24, 2019
@philwebb
Migrate Hamcrest assertions to AssertJ
95a9d46 
Migrate all existing `assertThat(..., Matcher)` assertions to AssertJ
and add checkstyle rules to ensure they don't return.

See gh-23022
philwebb added a commit that referenced this issue May 24, 2019
@philwebb
Migrate JUnit 4 assertions to AssertJ
9d74da0 
Migrate all existing JUnit 4 `assert...` based assertions to AssertJ
and add a checkstyle rule to ensure they don't return.

See gh-23022
@sbrannen sbrannen added the type: task A general task label May 24, 2019
sbrannen added a commit that referenced this issue May 24, 2019
@sbrannen
Migrate JUnit Jupiter assertions to AssertJ
5a1217c 
Migrate all existing JUnit Jupiter based assertions to AssertJ and add
Checkstyle rules to ensure they don't return.

See gh-23022
@philwebb philwebb reopened this May 24, 2019
@sbrannen
Copy link
Member

JUnit Jupiter assertions have been migrated to AssertJ now as well (5a1217c).

@sbrannen sbrannen self-assigned this May 24, 2019
rstoyanchev added a commit to rstoyanchev/spring-framework that referenced this issue May 24, 2019
@rstoyanchev
Adjust asserThat line length in messaging and web
1f947f9 
See spring-projectsgh-23022
rstoyanchev added a commit to rstoyanchev/spring-framework that referenced this issue May 24, 2019
@rstoyanchev
Adjust assertThat line length in test module
aa1caca 
See spring-projectsgh-23022
sbrannen added a commit to sbrannen/spring-framework that referenced this issue May 26, 2019
@sbrannen
Migrate TestNG assertions to AssertJ
4f4427f 
Migrate all existing TestNG based assertions to AssertJ and add
Checkstyle rules to ensure they don't return.

See spring-projectsgh-23022
@sbrannen
Copy link
Member

TestNG assertions have been migrated to AssertJ now as well (4f4427f).

@sbrannen sbrannen mentioned this issue Aug 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

@philwebb philwebb

Labels
type: task A general task
Projects
None yet
Milestone
5.2 M3
Development

No branches or pull requests
2 participants
@sbrannen @philwebb