Provide matched pattern information in WebFlux fn [SPR-17098]

[spring-projects-issues]

Brian Clozel opened SPR-17098 and commented

The annotation model in Spring WebFlux currently adds, as a exchange attribute, the information about the matched pattern for the current handler. This information is used by micrometer and the metrics support in Spring Boot to record metrics.

Spring WebFlux fn. is missing a similar feature - not having this feature is causing issues, such as cardinality explosion in URI tags.

Note that this is not only supported in the WebFlux annotation model, but also Spring MVC, RestTemplate and WebClient. This is the last piece of support missing. 

---

Reference URL: spring-projects/spring-boot#12757

Issue Links:

• WebFlux.fn puts wrong type of HandlerMapping.BEST_MATCHING_PATTERN_ATTRIBUTE [SPR-17395] #21928 WebFlux.fn puts wrong type of HandlerMapping.BEST_MATCHING_PATTERN_ATTRIBUTE
• PathPatternPredicate still changes variables after failed AndPredicate [SPR-17210] #21743 PathPatternPredicate still changes variables after failed AndPredicate

1 votes, 1 watchers

[spring-projects-issues]

Brian Clozel commented

I've tried to implement this but ran into #21743 - I guess we need to tackle that first and then we can consider this feature.

[spring-projects-issues]

Arjen Poutsma commented

Fixed in https://github.com/spring-projects/spring-framework/commit/88ab911cf1d712b00167f64c17b714a4822a0e32. The first matching path pattern is stored in the attribute RouterFunctions.MATCHING_PATTERN_ATTRIBUTE.