Restore lenient null return value for ConditionContext.getBeanFactory() [SPR-16866]

[spring-projects-issues]

Andy Wilkinson opened SPR-16866 and commented

Following the nullability changes in 5.0, three methods on ConditionContext may no longer return null, but may now throw an IlegalStateException instead. Those methods are:

• getRegistry()
• getBeanFactory()
• getClassLoader()

It would be useful if their javadoc documented that an IllegalStateException may now be thrown.

---

Affects: 5.0.6

Reference URL: spring-projects/spring-boot#13226

Referenced from: commits 50d6d90, 46a89d9

[spring-projects-issues]

Juergen Hoeller commented

It turns out that the deduced getBeanFactory() and getClassLoader() accessors should indeed be @Nullable since the registry may not be downcastable to the former whereas the resource loader's ClassLoader may actually be null (which is why null is also accepted as an argument to the common ClassUtils.forName method).

getRegistry() is arguably a special case since it is usually non-null, except for plain ClassPathScanningCandidateComponentProvider usage. I've retained the IllegalStateException there for the time being.