MockHttpServletResponse.setLocale(Locale) should set HttpHeaders.CONTENT_LANGUAGE header [SPR-16311]

[spring-projects-issues]

Dmitry Katsubo opened SPR-16311 and commented

As to my interpretation of ServletResponse#setLocale() JavaDoc which reads:

In the case of HTTP, the locale is communicated via the Content-Language header, the character encoding as part of the Content-Type header for text media types.

the corresponding implementation should set HttpHeaders.CONTENT_LANGUAGE which specifies the "language" of response content. Currently it sets HttpHeaders.ACCEPT_LANGUAGE, which is "language that client understands / prefers" - that one should be set by the client when it makes a request.

See also:

• org.mortbay.jetty.Response#setLocale()
• io.undertow.servlet.spec.HttpServletResponseImpl#setLocale()

---

Affects: 5.0.1

Issue Links:

• Mock MVC / RequestBuilder should handle Accept-Language header appropriately [SPR-15209] #19773 Mock MVC / RequestBuilder should handle Accept-Language header appropriately

Referenced from: commits 6df1a78

[spring-projects-issues]

Juergen Hoeller commented

Rossen Stoyanchev, this looks like a bug to me: The intent behind #19773 was to set common language headers behind the Servlet API request/response state methods, and in this case we seem to accidentally set the request-related header on the response?

[spring-projects-issues]

Rossen Stoyanchev commented

Indeed it's clearly a bug since ACCEPT_LANGUAGE is a request header.