Reduce access on headers for STOMP messaging [SPR-16165]

[spring-projects-issues]

Christoph Dreis opened SPR-16165 and commented

Hi,

it has been a while since my last PR, but I just noticed in our loadtests that there is quite some repetitive access on message headers when sending messages via STOMP over websockets. Although just being Map.get() calls underneath they add up at some point for us.

The attached PR minimizes access to those headers. Especially, but not limited to StompHeaderAccessor.getCommand().

I'd appreciate if this PR gets accepted.

Cheers,
Christoph

---

Affects: 4.3.12

Issue Links:

• Stomp Broker Relay may ignore configured destination prefixes [SPR-16265] #20812 Stomp Broker Relay may ignore configured destination prefixes

Referenced from: pull request #1587, and commits f861f18, 9fab208, 899994e

Backported to: 4.3.13

[spring-projects-issues]

Juergen Hoeller commented

Good catch, there is indeed no need for such repetitive resolution of the headers there. Merged into master now; I'll backport it to 4.3.x later this week.

[spring-projects-issues]

Christoph Dreis commented

Thanks Jürgen.