Upgrade AspectJ dependency to 1.8 final and apply latest ASM 5.0.2 patches [SPR-11212]

[spring-projects-issues]

Phil Webb opened SPR-11212 and commented

We're using AspectJ 1.8.0 RC2 for building as of Spring Framework 4.0.3. Once it went final, let's update our externally declared dependency from AspectJ 1.7.4 to 1.8.0 as well.

---

Affects: 4.0 GA

Issue Links:

• Basic Java 8 bytecode compatibility for Spring 3.2.x through ASM 5.0.2 [SPR-11656] #16279 Basic Java 8 bytecode compatibility for Spring 3.2.x through ASM 5.0.2
• Upgrade JCache dependency to 1.0 final [SPR-11640] #16263 Upgrade JCache dependency to 1.0 final
• Revisit spring-aspects 4.0.0 dependency on AspectJ 1.8.0.M1 [SPR-11248] #15873 Revisit spring-aspects 4.0.0 dependency on AspectJ 1.8.0.M1
• Default use of target 1.8 for Spring test compilation [SPR-11699] #16321 Default use of target 1.8 for Spring test compilation
• Upgrade to AspectJ 1.8.1 and Tomcat 8.0.9 [SPR-11957] #16573 Upgrade to AspectJ 1.8.1 and Tomcat 8.0.9

0 votes, 6 watchers

[spring-projects-issues]

Juergen Hoeller commented

Along with the AspectJ 1.8 upgrade in the Spring Framework 4.1 line, we're raising the test source compatibility for all of our modules to the 1.8 language level, and also compile all tests with the "-parameters" flag. As a side effect of that, it turns out that ASM 5 rejects CGLIB 3.1's visitors when encountering a parameters section in the bytecode; a patch to remove those over-eager assertions makes it work again (like we did back for ASM 4.2 to make it accept 1.8 bytecode).

Juergen

[spring-projects-issues]

Juergen Hoeller commented

AspectJ 1.8.0 final is available now. We're using it in our build and expose it as the recommended version in our Maven POMs as well, starting with 4.1.

Juergen

[spring-projects-issues]

Juergen Hoeller commented

Remaining patches from the just-released ASM 5.0.2 applied now as well.

Juergen

[spring-projects-issues]

Juergen Hoeller commented

For Spring Framework 4.0.4, I've upgraded our build to AspectJ 1.8 final and also applied the latest ASM 5.0.2 patches, but kept AspectJ 1.7.4 as the version in the POM for the time being (since we do intend to remain AspectJ 1.7 compatible and since AspectJ 1.8 hasn't seen much battle testing yet).

Juergen

[spring-projects-issues]

Juergen Hoeller commented

FYI, as of Spring Framework 4.0.6, we're not just using AspectJ 1.8.1 for building the spring-aspects module but are finally also exposing it as a suggested Maven dependency.

Juergen