EhCacheFactoryBean.afterPropertiesSet should be synchronized [SPR-11132]

[spring-projects-issues]

Vincent PERICART opened SPR-11132 and commented

When initializing 2 contexts at the same time, which both use a EhCacheFactoryBean, there is a potential race condition when :

• the same CacheManager instance is used
• both contexts have a cache with the same name

The error stack's root cause is :

Caused by: net.sf.ehcache.CacheException: Cannot replace XXX It does not equal the incumbent cache.
at net.sf.ehcache.CacheManager.replaceCacheWithDecoratedCache(CacheManager.java:1653)
at org.springframework.cache.ehcache.EhCacheFactoryBean.afterPropertiesSet(EhCacheFactoryBean.java:354)

The expected behaviour (which occurs most of the time) is that one of the contexts creates the cache, and the other one simply gets a reference to it.

---

Affects: 3.2.4

Referenced from: commits 1dc79f7, de890fd

[spring-projects-issues]

Juergen Hoeller commented

Good point. For that kind of scenario, the cache region check and the cache creation steps need to happen within a synchronized block on the CacheManager.

Fixed for 4.0 RC2; to be backported to 3.2.6.

Juergen