If the !profile selector is used the other profiles can be ignored in <beans profile="!foo,bar"/> [SPR-11093]

[spring-projects-issues]

Dave Syer opened SPR-11093 and commented

The !profile selector in AbstractEnvironment causes premature termination of loop.

Here's the code:

	@Override
	public boolean acceptsProfiles(String... profiles) {
		Assert.notEmpty(profiles, "Must specify at least one profile");
		for (String profile : profiles) {
			if (profile != null && profile.length() > 0 && profile.charAt(0) == '!') {
				return !isProfileActive(profile.substring(1));
			}
			if (isProfileActive(profile)) {
				return true;
			}
		}
		return false;
	}

So with <beans profile="!foo,bar"/> even if the "bar" profile is active the method returns false when "foo" is also active. Maybe that was intentional, but it doesn't match what I read in the Javadocs (and XSD docs).

---

Affects: 4.0 RC1

Backported to: 3.2.6

[spring-projects-issues]

Juergen Hoeller commented

Indeed, the implementation was simply wrong there - returning too early in case of multiple profile expressions. Fixed for 4.0 GA and 3.2.6 now.

Juergen