jUnit 4 and @Rule execution order [SPR-7705]

[spring-projects-issues]

Dries Schulten opened SPR-7705 and commented

When using Spring's SpringJUnit4ClassRunner to run unit-tests (the default runner for Spring's test base-classes) there is a execution order difference compared to default JUnit 4.

In the normal JUnit test runner (BlockJUnit4ClassRunner) it executes any @Rule's before running the @Before methods in a (base-)class. Spring's test runner first executes any @Before annotated methods before processing the @Rule's.

For example this causes a TestName JUnit rule (used to get the name of the currently executing test method) to be null in a @Before method.

The current SpringJUnit4ClassRunner fails on JUnit's own test suite because of this.

Attached is a patch with a fix (changes order of @Rule execution).

---

Affects: 3.0.5

Attachments:

• runner.diff (1.04 kB)

Issue Links:

• JUnit @Rule executes outside of transaction when using the TransactionalTestExecutionListener [SPR-9232] #13870 JUnit @Rule executes outside of transaction when using the TransactionalTestExecutionListener

Referenced from: commits b109a07

0 votes, 5 watchers

[spring-projects-issues]

Dave Syer commented

Done. It didn't affect our test cases and I'm not sure many people are using @Rules yet (except perhaps you and me).

[spring-projects-issues]

Stéphane Nicoll commented

... And us! We are now affected by that bug too. Could you please consider merging that one back to 3.0.6?

[spring-projects-issues]

Dave Syer commented

Stephane, it's probably best to open a new ticket for 3.0.6. I would open a SpringSource support ticket as well if you have a deadline.

[spring-projects-issues]

Stéphane Nicoll commented

Okay. Done (#13181)