Skip to content

DATAREST-1280 Add support sort collection resource by associated property. #2328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

DATAREST-1280 Add support sort collection resource by associated property. #2328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions ...ain/java/org/springframework/data/rest/webmvc/json/JacksonMappingAwareSortTranslator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,10 +192,6 @@ private List<String> mapPropertyPath(PersistentEntity<?, ?> rootEntity, List<Str

for (PersistentProperty<?> persistentProperty : persistentProperties) {

if (associations.isLinkableAssociation(persistentProperty)) {
return Collections.emptyList();
}

persistentPropertyPath.add(persistentProperty.getName());
}

Expand Down
16 changes: 8 additions & 8 deletions ...bmvc/src/test/java/org/springframework/data/rest/webmvc/json/SortTranslatorUnitTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2016-2022 original author or authors.
* Copyright 2016-2023 original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -117,19 +117,19 @@ void shouldMapKnownNestedProperties() {
assertThat(translatedSort.getOrderFor("embedded.someInterface")).isNotNull();
}

@Test // DATAREST-910
void shouldSkipWrongNestedProperties() {
@Test // DATAREST-1280
void shouldKnownAssociationProperties() {

Sort translatedSort = sortTranslator.translateSort(Sort.by("embedded.unknown"),
Sort translatedSort = sortTranslator.translateSort(Sort.by("association.name"),
mappingContext.getRequiredPersistentEntity(Plain.class));

assertThat(translatedSort).isEqualTo(Sort.unsorted());
assertTrue(translatedSort.isSorted());
}

@Test // DATAREST-910, DATAREST-976
void shouldSkipKnownAssociationProperties() {
@Test // DATAREST-910
void shouldSkipWrongNestedProperties() {

Sort translatedSort = sortTranslator.translateSort(Sort.by("association.name"),
Sort translatedSort = sortTranslator.translateSort(Sort.by("embedded.unknown"),
mappingContext.getRequiredPersistentEntity(Plain.class));

assertThat(translatedSort).isEqualTo(Sort.unsorted());
Expand Down