Adopt Java 17 language features #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use this link to re-run the recipe: https://app.moderne.io/builder/vxk6TUk8P?organizationId=NDAwOWYzMTAtY2NmMS00Mzk2LWJlZjctYzg2OWY0Zjk1ZDhi Co-authored-by: Moderne <[email protected]> Signed-off-by: Tim te Beek <[email protected]>
timtebeek
force-pushed
the
refactor/java-17-language-features
branch
from
2de9e8b to
3c5036b
Compare
|
For convenience I've pushed the String.formatted changes to a branch such that you can more easily compare and adopt: |
|
Thanks a lot. I'd appreciate the |
mp911de
changed the title
|
Sure! Here's that follow up PR after a bit of wrestling with rebase, conflicts and signing. One day I'll get it right on the first try. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Figured follow on from 9472418 by adopting some Java 17 language features. I'd intentionally left out a migration to
String#formatted, as that produces a lot more changes which might take some time to get used to. Can optionally follow up if desired.Use this link to re-run the recipe: https://app.moderne.io/builder/vxk6TUk8P?organizationId=NDAwOWYzMTAtY2NmMS00Mzk2LWJlZjctYzg2OWY0Zjk1ZDhi