Skip to content

Fix loading of nested embedded entities #1685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Fix loading of nested embedded entities #1685

wants to merge 3 commits into from

Conversation

schauder
Copy link
Contributor

@schauder schauder commented Dec 4, 2023 •
edited
Loading

Closes #1676

@schauder schauder requested a review from mp911de December 4, 2023 15:07
@mp911de mp911de added the type: bug A general bug label Dec 4, 2023
@blommish
Copy link

blommish commented Dec 5, 2023

That was a fast fix, thanks @schauder !

@schauder
Copy link
Contributor Author

schauder commented Dec 5, 2023

@blommish Sorry, I referenced the wrong issue. :–(

@mp911de mp911de changed the title Fix loading of nested embedded entities. Fix loading of nested embedded entities Dec 5, 2023
@mp911de
Recursively check embedded property loading.
1319088 
Also, avoid falling back into hasValue(…) code path.
mp911de pushed a commit that referenced this pull request Dec 13, 2023
@schauder @mp911de
Fix loading of nested embedded entities.
e5bcc4a 
Closes #1676
Original pull request: #1685
mp911de added a commit that referenced this pull request Dec 13, 2023
@mp911de
Recursively check embedded property loading.
b20461c 
Also, avoid falling back into hasValue(…) code path.

See #1676
Original pull request: #1685
mp911de pushed a commit that referenced this pull request Dec 13, 2023
@schauder @mp911de
Fix loading of nested embedded entities.
e7558fa 
Closes #1676
Original pull request: #1685
mp911de added a commit that referenced this pull request Dec 13, 2023
@mp911de
Recursively check embedded property loading.
a40dbc9 
Also, avoid falling back into hasValue(…) code path.

See #1676
Original pull request: #1685
@mp911de mp911de added this to the 3.2.1 (2023.1.1) milestone Dec 13, 2023
@mp911de mp911de closed this Dec 13, 2023
@mp911de mp911de deleted the issue/npe branch December 13, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mp911de mp911de Awaiting requested review from mp911de

Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
3.2.1 (2023.1.1)
Development

Successfully merging this pull request may close these issues.

NullPointerException when loading deeply nested embedded entities
3 participants
@schauder @blommish @mp911de