Skip to content

Refine code samples in reference docs #2784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Refine code samples in reference docs #2784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e887237
Add missing comma in indexes.adoc.
junghoon-vans Nov 23, 2023
5529841
Refine generic map definition statements.
junghoon-vans Nov 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/antora/modules/ROOT/pages/redis/redis-repositories/indexes.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ public class Person {

// ... other properties omitted

Map<String,String> attributes; <1>
Map<String Person> relatives; <2>
Map<String, String> attributes; <1>
Map<String, Person> relatives; <2>
List<Address> addresses; <3>
}
----
Expand Down
10 changes: 5 additions & 5 deletions src/main/antora/modules/ROOT/pages/redis/redis-repositories/mapping.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ addresses.[work].city = "...
CAUTION: Due to the flat representation structure, Map keys need to be simple types, such as ``String`` or ``Number``.

Mapping behavior can be customized by registering the corresponding `Converter` in `RedisCustomConversions`.
Those converters can take care of converting from and to a single `byte[]` as well as `Map<String,byte[]>`.
Those converters can take care of converting from and to a single `byte[]` as well as `Map<String, byte[]>`.
The first one is suitable for (for example) converting a complex type to (for example) a binary JSON representation that still uses the default mappings hash structure.
The second option offers full control over the resulting hash.

Expand Down Expand Up @@ -140,15 +140,15 @@ address = { city : "emond's field", country : "andor" }

The following example shows two examples of `Map` converters:

.Sample Map<String,byte[]> Converters
.Sample Map<String, byte[]> Converters
====
[source,java]
----
@WritingConverter
public class AddressToMapConverter implements Converter<Address, Map<String,byte[]>> {
public class AddressToMapConverter implements Converter<Address, Map<String, byte[]>> {

@Override
public Map<String,byte[]> convert(Address source) {
public Map<String, byte[]> convert(Address source) {
return singletonMap("ciudad", source.getCity().getBytes());
}
}
Expand All @@ -157,7 +157,7 @@ public class AddressToMapConverter implements Converter<Address, Map<String,byte
public class MapToAddressConverter implements Converter<Map<String, byte[]>, Address> {

@Override
public Address convert(Map<String,byte[]> source) {
public Address convert(Map<String, byte[]> source) {
return new Address(new String(source.get("ciudad")));
}
}
Expand Down