Skip to content

Remove unnecessary method call in adapter. #2774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove unnecessary method call in adapter. #2774

wants to merge 1 commit into from

Conversation

junghoon-vans
Copy link
Contributor

The keyspace is already a String type, so there is no need to call asString.

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 17, 2023
@jxblum
Copy link
Contributor

jxblum commented Nov 17, 2023 •
edited
Loading

Hi @junghoon-vans,

It appears at one point (before DATAREDIS-664) the keyspace method parameter (and ID) where Serializable, then changed to a String in order to adapt to API changes in SD KeyValue.

Apparently, this was overlooked when the method signatures changed.

Thank you for catching this and contributing a PR.

@jxblum jxblum self-assigned this Nov 17, 2023
@jxblum jxblum added type: task A general task in: cache RedisCache and CacheManager and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 17, 2023
@jxblum jxblum added this to the 3.1.7 (2023.0.7) milestone Nov 17, 2023
jxblum added a commit to jxblum/spring-data-redis that referenced this pull request Nov 17, 2023
@jxblum
Polishing.
96625a4 
Rename asString(:Object) to toString(:Object) for consistency with toBytes(..).

Closes spring-projects#2774
@jxblum jxblum closed this in 482eab9 Nov 17, 2023
jxblum added a commit that referenced this pull request Nov 17, 2023
@jxblum
Polishing.
76cdf48 
Rename asString(:Object) to toString(:Object) for consistency with toBytes(..).

Original pull request: #2774
jxblum pushed a commit to jxblum/spring-data-redis that referenced this pull request Nov 17, 2023
@junghoon-vans @jxblum
Remove unnecessary method call in RedisKeyValueAdapter.
84a3fc4 
Closes spring-projects#2774
jxblum added a commit to jxblum/spring-data-redis that referenced this pull request Nov 17, 2023
@jxblum
Polishing.
af017a8 
Rename asString(:Object) to toString(:Object) for consistency with toBytes(..).

Original pull request: spring-projects#2774
jxblum pushed a commit to jxblum/spring-data-redis that referenced this pull request Nov 17, 2023
@junghoon-vans @jxblum
Remove unnecessary method call in RedisKeyValueAdapter.
e151e70 
Closes spring-projects#2774
jxblum added a commit to jxblum/spring-data-redis that referenced this pull request Nov 17, 2023
@jxblum
Polishing.
8b57795 
Rename asString(:Object) to toString(:Object) for consistency with toBytes(..).

Original pull request: spring-projects#2774
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jxblum jxblum

Labels
in: cache RedisCache and CacheManager type: task A general task
Projects
None yet
Milestone
3.1.7 (2023.0.7)
Development

Successfully merging this pull request may close these issues.
3 participants
@junghoon-vans @jxblum @spring-projects-issues