ReactiveRedisConnection close method is blocking [DATAREDIS-999]

[spring-projects-issues]

haicoder opened DATAREDIS-999 and commented

When I use ReactiveRedisTemplate in my spring boot application, I always get this error below:

2019/06/18 23:05:54.205 [b43b485d-7249-4ccb-ac23-ae954638ab4e] [parallel-2] [ERROR] reactor.core.publisher.Operators - Operator called default onErrorDropped
java.lang.IllegalStateException: block()/blockFirst()/blockLast() are blocking, which is not supported in thread parallel-2
        at reactor.core.publisher.BlockingSingleSubscriber.blockingGet(BlockingSingleSubscriber.java:77)
        at reactor.core.publisher.Mono.block(Mono.java:1494)
        at org.springframework.data.redis.connection.ReactiveRedisConnection.close(ReactiveRedisConnection.java:60)
        at org.springframework.data.redis.core.ReactiveRedisTemplate.lambda$doInConnection$3(ReactiveRedisTemplate.java:198)
        at reactor.core.publisher.FluxDoFinally$DoFinallySubscriber.runFinally(FluxDoFinally.java:156)
        at reactor.core.publisher.FluxDoFinally$DoFinallySubscriber.onComplete(FluxDoFinally.java:139)

When I inspect the error stacktrace, I find there is a blocking method in ReactiveRedisConnection.close() method.

@Override
default void close() {
   closeLater().block();
}

And I also don't know why it's run on the parallel scheduler.

So how can I fix this error, or how to use correctly, thanks!

 

---

Affects: 2.1.9 (Lovelace SR9)

Issue Links:

• DATAREDIS-965 ReactiveRedisTemplate is using block()
  ("supersedes")

Referenced from: pull request #461, and commits feed7b6, 766bd8b, 2131f0c, dfa366d, 3c9c4ac

1 votes, 6 watchers

[spring-projects-issues]

Mark Paluch commented

The bug is on our side. We need to call closeAsync in doInConnection and execute methods. 

[spring-projects-issues]

Christoph Strobl commented

No back port to 2.1.x due to missing (async) bits in LettuceConnectionProvider

[spring-projects-issues]

Ankush Sharma commented

Mark Paluch Still with spring-data-redis 2.2.0 version, I am seeing the same error :

.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.IllegalStateException: block()/blockFirst()/blockLast() are blocking, which is not supported in thread reactor-http-epoll-7
at reactor.core.publisher.BlockingSingleSubscriber.blockingGet(BlockingSingleSubscriber.java:77)
at reactor.core.publisher.Mono.block(Mono.java:1494)
at org.springframework.data.redis.connection.ReactiveRedisConnection.close(ReactiveRedisConnection.java:60)
at org.springframework.data.redis.core.script.DefaultReactiveScriptExecutor.lambda$execute$7(DefaultReactiveScriptExecutor.java:167)
at reactor.core.publisher.FluxDoFinally$DoFinallySubscriber.runFinally(FluxDoFinally.java:156)
 

 

[spring-projects-issues]

bradfordChiang commented

Mark Paluch Ankush Sharma

Hello Gents,

Has this issue been fixed? As I still see the error.

closeLater().block();

Even though the closeLater() return a Mono.

My lib version is spring-data-redis 2.2.3;  lettuce-core 5.2.1 

2019-12-13 18:22:16,194 ERROR [     parallel-5]                  r.u.Loggers$Slf4JLogger:    Scheduler worker in group main failed with an uncaught exception2019-12-13 18:22:16,194 ERROR [     parallel-5]                  r.u.Loggers$Slf4JLogger:    Scheduler worker in group main failed with an uncaught exception java.lang.IllegalStateException: block()/blockFirst()/blockLast() are blocking, which is not supported in thread parallel-5 at reactor.core.publisher.BlockingSingleSubscriber.blockingGet(BlockingSingleSubscriber.java:77) at reactor.core.publisher.Mono.block(Mono.java:1663) at org.springframework.data.redis.connection.ReactiveRedisConnection.close(ReactiveRedisConnection.java:60) at org.springframework.data.redis.core.script.DefaultReactiveScriptExecutor.lambda$execute$7(DefaultReactiveScriptExecutor.java:167)

 

Thanks

Regards,

Bradford

 

[spring-projects-issues]

bradfordChiang commented

!image-2019-12-13-18-30-29-336.png!

[spring-projects-issues]

Mark Paluch commented

Thanks for report. This issue is about ReactiveRedisTemplate calling the blocking close() method. Your stack trace shows a new place which is the DefaultReactiveScriptExecutor. Can you file a new issue? Please mind the formatting of the stack trace and code

[spring-projects-issues]

bradfordChiang commented

I have start service with redis is up, then stop the redis, trigger a restful call to the service, then ended up with no response back forever. Below is the full stack:

Many thanks!!

 

2019-12-13 18:42:52,993 ERROR [     parallel-7]                  r.u.Loggers$Slf4JLogger:    Operator called default onErrorDropped2019-12-13 18:42:52,993 ERROR [     parallel-7]                  r.u.Loggers$Slf4JLogger:    Operator called default onErrorDropped java.lang.IllegalStateException: block()/blockFirst()/blockLast() are blocking, which is not supported in thread parallel-7 at reactor.core.publisher.BlockingSingleSubscriber.blockingGet(BlockingSingleSubscriber.java:77) at reactor.core.publisher.Mono.block(Mono.java:1663) at org.springframework.data.redis.connection.ReactiveRedisConnection.close(ReactiveRedisConnection.java:60) at org.springframework.data.redis.core.script.DefaultReactiveScriptExecutor.lambda$execute$7(DefaultReactiveScriptExecutor.java:167) at reactor.core.publisher.FluxDoFinally$DoFinallySubscriber.runFinally(FluxDoFinally.java:156) at reactor.core.publisher.FluxDoFinally$DoFinallySubscriber.cancel(FluxDoFinally.java:145) at reactor.core.publisher.Operators$MultiSubscriptionSubscriber.drainLoop(Operators.java:2013) at reactor.core.publisher.Operators$MultiSubscriptionSubscriber.drain(Operators.java:1982) at reactor.core.publisher.Operators$MultiSubscriptionSubscriber.cancel(Operators.java:1794) at reactor.core.publisher.MonoReduceSeed$ReduceSeedSubscriber.cancel(MonoReduceSeed.java:96) at reactor.core.publisher.FluxMapFuseable$MapFuseableSubscriber.cancel(FluxMapFuseable.java:167) at reactor.core.publisher.Operators.terminate(Operators.java:1070) at reactor.core.publisher.MonoFlatMap$FlatMapMain.cancel(MonoFlatMap.java:180) at reactor.core.publisher.Operators.terminate(Operators.java:1070) at reactor.core.publisher.MonoFlatMap$FlatMapInner.cancel(MonoFlatMap.java:264) at reactor.core.publisher.MonoFlatMap$FlatMapMain.cancel(MonoFlatMap.java:181) at reactor.core.publisher.Operators.terminate(Operators.java:1070) at reactor.core.publisher.BaseSubscriber.cancel(BaseSubscriber.java:228) at reactor.core.publisher.Operators$MultiSubscriptionSubscriber.drainLoop(Operators.java:2013) at reactor.core.publisher.Operators$MultiSubscriptionSubscriber.drain(Operators.java:1982) at reactor.core.publisher.Operators$MultiSubscriptionSubscriber.cancel(Operators.java:1794) at reactor.core.publisher.FluxTimeout$TimeoutMainSubscriber.handleTimeout(FluxTimeout.java:287) at reactor.core.publisher.FluxTimeout$TimeoutMainSubscriber.doTimeout(FluxTimeout.java:273) at reactor.core.publisher.FluxTimeout$TimeoutTimeoutSubscriber.onNext(FluxTimeout.java:390) at reactor.core.publisher.StrictSubscriber.onNext(StrictSubscriber.java:89) at reactor.core.publisher.FluxOnErrorResume$ResumeSubscriber.onNext(FluxOnErrorResume.java:73) at reactor.core.publisher.MonoDelay$MonoDelayRunnable.run(MonoDelay.java:117) at reactor.core.scheduler.SchedulerTask.call(SchedulerTask.java:68) at reactor.core.scheduler.SchedulerTask.call(SchedulerTask.java:28) at java.base/java.util.concurrent.FutureTask.run$$$capture(FutureTask.java:264) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java) at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:834)2019-12-13 18:42:52,993 ERROR [     parallel-7]                  r.u.Loggers$Slf4JLogger:    Scheduler worker in group main failed with an uncaught exception java.lang.IllegalStateException: block()/blockFirst()/blockLast() are blocking, which is not supported in thread parallel-7 at reactor.core.publisher.BlockingSingleSubscriber.blockingGet(BlockingSingleSubscriber.java:77) at reactor.core.publisher.Mono.block(Mono.java:1663) at org.springframework.data.redis.connection.ReactiveRedisConnection.close(ReactiveRedisConnection.java:60) at org.springframework.data.redis.core.script.DefaultReactiveScriptExecutor.lambda$execute$7(DefaultReactiveScriptExecutor.java:167) at reactor.core.publisher.FluxDoFinally$DoFinallySubscriber.runFinally(FluxDoFinally.java:156) at reactor.core.publisher.FluxDoFinally$DoFinallySubscriber.cancel(FluxDoFinally.java:145) at reactor.core.publisher.Operators$MultiSubscriptionSubscriber.drainLoop(Operators.java:2013) at reactor.core.publisher.Operators$MultiSubscriptionSubscriber.drain(Operators.java:1982) at reactor.core.publisher.Operators$MultiSubscriptionSubscriber.cancel(Operators.java:1794) at reactor.core.publisher.MonoReduceSeed$ReduceSeedSubscriber.cancel(MonoReduceSeed.java:96) at reactor.core.publisher.FluxMapFuseable$MapFuseableSubscriber.cancel(FluxMapFuseable.java:167) at reactor.core.publisher.Operators.terminate(Operators.java:1070) at reactor.core.publisher.MonoFlatMap$FlatMapMain.cancel(MonoFlatMap.java:180) at reactor.core.publisher.Operators.terminate(Operators.java:1070) at reactor.core.publisher.MonoFlatMap$FlatMapInner.cancel(MonoFlatMap.java:264) at reactor.core.publisher.MonoFlatMap$FlatMapMain.cancel(MonoFlatMap.java:181) at reactor.core.publisher.Operators.terminate(Operators.java:1070) at reactor.core.publisher.BaseSubscriber.cancel(BaseSubscriber.java:228) at reactor.core.publisher.Operators$MultiSubscriptionSubscriber.drainLoop(Operators.java:2013) at reactor.core.publisher.Operators$MultiSubscriptionSubscriber.drain(Operators.java:1982) at reactor.core.publisher.Operators$MultiSubscriptionSubscriber.cancel(Operators.java:1794) at reactor.core.publisher.FluxTimeout$TimeoutMainSubscriber.handleTimeout(FluxTimeout.java:287) at reactor.core.publisher.FluxTimeout$TimeoutMainSubscriber.doTimeout(FluxTimeout.java:273) at reactor.core.publisher.FluxTimeout$TimeoutTimeoutSubscriber.onNext(FluxTimeout.java:390) at reactor.core.publisher.StrictSubscriber.onNext(StrictSubscriber.java:89) at reactor.core.publisher.FluxOnErrorResume$ResumeSubscriber.onNext(FluxOnErrorResume.java:73) at reactor.core.publisher.MonoDelay$MonoDelayRunnable.run(MonoDelay.java:117) at reactor.core.scheduler.SchedulerTask.call(SchedulerTask.java:68) at reactor.core.scheduler.SchedulerTask.call(SchedulerTask.java:28) at java.base/java.util.concurrent.FutureTask.run$$$capture(FutureTask.java:264) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java) at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:834)2019-12-13 18:43:18,332 INFO [xecutorLoop-1-4]         i.n.u.i.l.AbstractInternalLogger:    Reconnecting, last destination was localhost:63792019-12-13 18:43:18,332 INFO [xecutorLoop-1-2]         i.n.u.i.l.AbstractInternalLogger:    Reconnecting, last destination was localhost:63792019-12-13 18:43:18,332 INFO [xecutorLoop-1-3]         i.n.u.i.l.AbstractInternalLogger:    Reconnecting, last destination was localhost:63792019-12-13 18:43:18,334 WARN [ioEventLoop-4-4]         i.n.u.i.l.AbstractInternalLogger:    Cannot reconnect to [localhost:6379]: Connection refused: localhost/127.0.0.1:63792019-12-13 18:43:18,334 WARN [ioEventLoop-4-3]         i.n.u.i.l.AbstractInternalLogger:    Cannot reconnect to [localhost:6379]: Connection refused: localhost/127.0.0.1:63792019-12-13 18:43:18,335 WARN [ioEventLoop-4-1]         i.n.u.i.l.AbstractInternalLogger:    Cannot reconnect to [localhost:6379]: Connection refused: localhost/127.0.0.1:6379

[spring-projects-issues]

bradfordChiang commented

Thanks. Sure I will