geoNear() queries fail when the accompanying query returns no results [DATAMONGO-1361]

[spring-projects-issues]

Bjorn Harvold opened DATAMONGO-1361 and commented

I found that if I a run a geoNear query with an accompanying search query that doesn't return any results, I encounter an NPE here.

java.lang.NullPointerException
	at org.springframework.data.mongodb.core.MongoTemplate.geoNear(MongoTemplate.java:667)
	at org.springframework.data.mongodb.core.MongoTemplate.geoNear(MongoTemplate.java:618)

Example document:

{
	"id": "1",
	"available": false,
        "location": {
            "type": "Point",
            "coordinates": [
              40.758934,
              -73.992514
            ]
        }
}

if the query looks like this:

NearQuery q = NearQuery.near(point).maxDistance(new Distance(maxDistance, Metrics.KILOMETERS));
q.query(where("available").is(true));

You get the NPE. Let me know if you need more information from me

---

Affects: 1.8.2 (Gosling SR2)

Referenced from: commits 160de0a, 2949908, 8ddbc3c

Backported to: 1.8.4 (Gosling SR4), 1.7.3 (Fowler SR3)

[spring-projects-issues]

Oliver Drotbohm commented

It looks like the stats field is null at this point which — according to the MongoDB reference documentation — should never be the case.

It feels slightly wrong to explicitly handle that case because it indicates a server problem to some degree (is it really correct to fall back to 0 for the average distance, if results are available but no stats are present?). It looks like we'd mask broken results which I still haven't made up my mind on whether that's good or bad.

Which MongoDB Java driver version are you using? Have you checked the driver's issue tracker for a maybe already existing ticket?

[spring-projects-issues]

Bjorn Harvold commented

I am limited to using v2.14.1 as the Axon Framework is currently not compatible with the v3.x. API (http://issues.axonframework.org/youtrack/issue/AXON-341)

Don't know if the 3.x driver fixes this issue

[spring-projects-issues]

Oliver Drotbohm commented

It's not the driver, it's the server causing this. I pushed a mitigating change so that you should see this working now in the master and maintenance branches for Gosling and Fowler