DATAJPA-1818 - Implements CrudRepository.delete(Iterable<ID> ids). #435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mp911de
reviewed
Nov 19, 2020
| @@ -218,6 +218,16 @@ public void deleteAll(Iterable<? extends T> entities) { | |||
| } | |||
| } | |||
|
|
|||
| @Override | |||
| public void deleteAllById(Iterable<? extends ID> ids) { | |||
There was a problem hiding this comment.
Should we also add a deleteAllByIdInBatch variant?
There was a problem hiding this comment.
I added deleteAllByIdInBatch.
It does not work with EclipseLink since their handling of IN queries seems still to be broken.
Renamed deleteInBatch to deleteAllInBatch to match the naming conventions of CrudRepository and the new method. The old variant is deprecated and delegates to the new one.
Handling of IN-Queries in Eclipselink is still broken.
schauder
force-pushed
the
issue/DATAJPA-1818
branch
from
dd7fbb0 to
833445b
Compare
mp911de
approved these changes
Nov 25, 2020
mp911de
pushed a commit
that referenced
this pull request
Nov 25, 2020
…ds). Handling of IN-Queries in Eclipselink is still broken so this properly works only with Hibernate. Original pull request: #435.
mp911de
pushed a commit
that referenced
this pull request
Nov 25, 2020
…rudRepository. Original pull request: #435.
mp911de
added a commit
that referenced
this pull request
Nov 25, 2020
Reorder methods. Fix Javadoc. Original pull request: #435.
|
That's merged and polished now. |
mp911de
added a commit
that referenced
this pull request
Nov 25, 2020
Add missing Transactional annotations. Original pull request: #435.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge right after DATACMNS-800