DATAJPA-1818 - Rename JpaRepository.deleteInBatch to match names in CrudRepository

Author: schauder

src/main/java/org/springframework/data/jpa/repository/JpaRepository.java

@@ -77,12 +77,28 @@ public interface JpaRepository<T, ID> extends PagingAndSortingRepository<T, ID>,
 	<S extends T> S saveAndFlush(S entity);
 
 	/**
-	 * Deletes the given entities in a batch which means it will create a single {@link Query}. Assume that we will clear
-	 * the {@link javax.persistence.EntityManager} after the call.
+	 * Deletes the given entities in a batch which means it will create a single {@link Query}.
+	 *
+	 * This kind of operation leaves JPAs first level cache and the database out of sync.
+	 * Consider flushing the `EntityManager` before calling this method.
 	 *
 	 * @param entities
+	 * @deprecated Use {@link #deleteAllInBatch(Iterable)} instead.
+	 */
+	@Deprecated
+	default void deleteInBatch(Iterable<T> entities){deleteAllInBatch(entities);}
+
+	/**
+	 * Deletes the given entities in a batch which means it will create a single {@link Query}.
+	 *
+	 * This kind of operation leaves JPAs first level cache and the database out of sync.
+	 * Consider flushing the `EntityManager` before calling this method.
+	 *
+	 * @param entities
+	 *
+	 * @since 3.0
 	 */
-	void deleteInBatch(Iterable<T> entities);
+	void deleteAllInBatch(Iterable<T> entities);
 
 
 	/**

src/main/java/org/springframework/data/jpa/repository/support/SimpleJpaRepository.java

@@ -234,7 +234,7 @@ public void deleteAllById(Iterable<? extends ID> ids) {
 	 */
 	@Transactional
 	@Override
-	public void deleteInBatch(Iterable<T> entities) {
+	public void deleteAllInBatch(Iterable<T> entities) {
 
 		Assert.notNull(entities, "Entities must not be null!");
 

src/test/java/org/springframework/data/jpa/repository/UserRepositoryTests.java

@@ -25,7 +25,6 @@
 import static org.springframework.data.jpa.domain.sample.UserSpecifications.*;
 
 import java.util.ArrayList;
-import java.util.Arrays;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.HashSet;
@@ -259,7 +258,7 @@ void batchDeleteCollectionOfEntities() {
 
 		long before = repository.count();
 
-		repository.deleteInBatch(asList(firstUser, secondUser));
+		repository.deleteAllInBatch(asList(firstUser, secondUser));
 
 		assertThat(repository.existsById(firstUser.getId())).isFalse();
 		assertThat(repository.existsById(secondUser.getId())).isFalse();