DATAJPA-1635 - Removed superfluous logic from evaluation of count query. #400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic existed only for handling a scenario that was only created by bogus unit tests. A count query must never return anything but a single result. Signed-off-by: Jens Schauder <[email protected]>
5 tasks
|
Turns out the unit test wasn't that bogus after all. The generated count query behaves as the unit test describes if the original query contains a |
JIANGc
pushed a commit
to JIANGc/spring-data-jpa
that referenced
this pull request
Dec 20, 2019
Merge pr spring-projects#400 and add some logic for HQL when there is group by clause. Original pull request: spring-projects#400.
JIANGc
pushed a commit
to JIANGc/spring-data-jpa
that referenced
this pull request
Dec 25, 2019
Useless capturing group removed in COUNT_MATCH. Original pull request: spring-projects#400.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic existed only for handling a scenario that was only created by bogus unit tests.
A count query must never return anything but a single result.
https://jira.spring.io/browse/DATAJPA-1635