Skip to content

DATAJPA-1635 - Removed superfluous logic from evaluation of count query. #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

schauder
Copy link
Contributor

The logic existed only for handling a scenario that was only created by bogus unit tests.
A count query must never return anything but a single result.

https://jira.spring.io/browse/DATAJPA-1635

The logic existed only for handling a scenario that was only created by bogus unit tests.
A count query must never return anything but a single result.

Signed-off-by: Jens Schauder <[email protected]>
@schauder
Copy link
Contributor Author

Turns out the unit test wasn't that bogus after all. The generated count query behaves as the unit test describes if the original query contains a group by.

JIANGc pushed a commit to JIANGc/spring-data-jpa that referenced this pull request Dec 20, 2019
Merge pr spring-projects#400 and add some logic for HQL when there is group by clause.

Original pull request: spring-projects#400.
JIANGc pushed a commit to JIANGc/spring-data-jpa that referenced this pull request Dec 25, 2019
Useless capturing group removed in COUNT_MATCH.

Original pull request: spring-projects#400.
@schauder schauder closed this Mar 9, 2020
@schauder schauder deleted the issue/DATAJPA-1635 branch February 26, 2021 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant