Skip to content

DATAJPA-1449 - Prepare removal of Specifications #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

koraktor
Copy link
Contributor

Specifications is deprecated since 2.0. This patch prepares the code for removing it completely.

  • Moves static helper code into a private helper class
  • Removes references to Specifications from Specification

This should make it pretty straight forward to remove the class completely (in 3.0?) without affecting compatibility right now.

`Specifications` is deprecated since 2.0. This patch prepares the
code for removing it completely.

 * Moves static helper code into a private helper class
 * Removes references to `Specifications` from `Specification`
@odrotbohm
Copy link
Member

Great suggestion! I think we can even go ahead and remove Specifications for 2.2 as we've deprecated it in 2.0 already. Would you mind adapting your PR accordingly?

The functionality is now completely covered by `Specification`
itself.
@koraktor
Copy link
Contributor Author

No problem, done.

@schauder schauder changed the title Prepare removal of Specifications DATAJPA-1449 - Prepare removal of Specifications Nov 1, 2018
schauder pushed a commit that referenced this pull request Nov 1, 2018
`Specifications` is deprecated since 2.0. This removes it completely.

 * Moves static helper code into a private helper class.
 * Removes references to `Specifications` from `Specification`.

 Original pull request: #300.
@schauder
Copy link
Contributor

schauder commented Nov 1, 2018

That's squashed and merged. Thanks.

@schauder schauder closed this Nov 1, 2018
stsypanov pushed a commit to stsypanov/spring-data-jpa that referenced this pull request Dec 13, 2019
`Specifications` is deprecated since 2.0. This removes it completely.

 * Moves static helper code into a private helper class.
 * Removes references to `Specifications` from `Specification`.

 Original pull request: spring-projects#300.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants