DATACOUCH-1066 - Make QueryCriteria key a N1qlExpression. #1082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a merge of mmonti's changeset into master. The changeset was made on top of 4.1.x instead of master so it has a little catching up to do.
mikereiche
force-pushed
the
datacouch_1066_make_querycriteria_key_n1qlexpression
branch
from
4cc7cdb to
a1df41d
Compare
mikereiche
commented
Feb 17, 2021
| @@ -52,6 +55,7 @@ | |||
| private final StringBasedN1qlQueryParser queryParser; | |||
| private final QueryMethod queryMethod; | |||
| private final CouchbaseConverter couchbaseConverter; | |||
| private static final SpelExpressionParser SPEL_PARSER = new SpelExpressionParser(); | |||
| private final N1QLExpression parsedExpression; | |||
There was a problem hiding this comment.
Never used. Removing.
mikereiche
added a commit
that referenced
this pull request
Feb 17, 2021
This is a merge of mmonti's changeset into master. The changeset was made on top of 4.1.x instead of master so it has a little catching up to do. Original pull request #1082 Co-authored-by: mikereiche <[email protected]>
| @@ -124,7 +126,7 @@ void findByMatchingQuery() { | |||
|
|
|||
| couchbaseTemplate.upsertById(User.class).all(Arrays.asList(user1, user2, specialUser)); | |||
|
|
|||
| Query specialUsers = new Query(QueryCriteria.where("firstname").like("special")); | |||
| Query specialUsers = new Query(QueryCriteria.where(i("firstname")).like("special")); | |||
There was a problem hiding this comment.
It might already be in the PR, but I wasn't paying close enough attention
But can the value methods take N1QLExpression's to? I can imagine that somewhere someone might want to use a built in N1QL method to compute the value to compare against..
mikereiche
deleted the
datacouch_1066_make_querycriteria_key_n1qlexpression
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a merge of mmonti's changeset into master. The changeset was made
on top of 4.1.x instead of master so it has a little catching up to do.
Closes #1066